]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
crypto: af_alg - use list_for_each_entry() in af_alg_count_tsgl()
authorEric Biggers <ebiggers@google.com>
Thu, 10 Jan 2019 20:18:01 +0000 (12:18 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 18 Jan 2019 10:43:43 +0000 (18:43 +0800)
af_alg_count_tsgl() iterates through a list without modifying it, so use
list_for_each_entry() rather than list_for_each_entry_safe().  Also make
the pointers 'const' to make it clearer that nothing is modified.

No actual change in behavior.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/af_alg.c

index ccae4a7ada8ab68d04bac8b0a1355edf3ec87947..1dd573a441279115a7629989e6ffaa8b54d17258 100644 (file)
@@ -530,17 +530,17 @@ static int af_alg_alloc_tsgl(struct sock *sk)
  */
 unsigned int af_alg_count_tsgl(struct sock *sk, size_t bytes, size_t offset)
 {
-       struct alg_sock *ask = alg_sk(sk);
-       struct af_alg_ctx *ctx = ask->private;
-       struct af_alg_tsgl *sgl, *tmp;
+       const struct alg_sock *ask = alg_sk(sk);
+       const struct af_alg_ctx *ctx = ask->private;
+       const struct af_alg_tsgl *sgl;
        unsigned int i;
        unsigned int sgl_count = 0;
 
        if (!bytes)
                return 0;
 
-       list_for_each_entry_safe(sgl, tmp, &ctx->tsgl_list, list) {
-               struct scatterlist *sg = sgl->sg;
+       list_for_each_entry(sgl, &ctx->tsgl_list, list) {
+               const struct scatterlist *sg = sgl->sg;
 
                for (i = 0; i < sgl->cur; i++) {
                        size_t bytes_count;