]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
remoteproc: qcom: q6v5-pil: fix modem hang on SDM845 after axis2 clk unvote
authorSibi Sankar <sibis@codeaurora.org>
Mon, 9 Jul 2018 15:12:20 +0000 (20:42 +0530)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 10 Jul 2018 21:08:44 +0000 (14:08 -0700)
GCC_MSS_AXIS2 clock is used for disabling boot IMEM (a part of
AP boot up). With Boot IMEM disable now a part TZ/ATF, AXIS2
clock is no longer required post AP boot up and expected to
remain untouched. However if the clock is turned ON after Q6
is brought out of reset and later turned off, it results in
modem hang. When Q6 attempts a power collapse the internal
handshaking to check if AXIS2 is idle never goes through since
it is turned off preventing the RSC from getting triggered,
leaving modem in a funky state. Hence removing AXIS2 clk
enable/disable from the driver.

Reported-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_q6v5_pil.c

index e04319573c9114c1c7456f7d0680eb27db07dd3f..d7a4b9eca5d25bc6d7d37257f23bb424bc45541e 100644 (file)
@@ -1243,7 +1243,6 @@ static const struct rproc_hexagon_res sdm845_mss = {
        .hexagon_mba_image = "mba.mbn",
        .proxy_clk_names = (char*[]){
                        "xo",
-                       "axis2",
                        "prng",
                        NULL
        },