]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
interconnect: Check for valid path in icc_set_bw()
authorGeorgi Djakov <georgi.djakov@linaro.org>
Mon, 6 Jan 2020 17:27:46 +0000 (19:27 +0200)
committerGeorgi Djakov <georgi.djakov@linaro.org>
Tue, 7 Jan 2020 07:30:09 +0000 (09:30 +0200)
Use IS_ERR() to ensure that the path passed to icc_set_bw() is valid.

Reviewed-by: Evan Green <evgreen@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
drivers/interconnect/core.c

index 10dde5df92510be0d6a5139a208fe8ef4ff9507c..f277e467156f759de71af874557be07dfaa3e25b 100644 (file)
@@ -495,9 +495,12 @@ int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw)
        size_t i;
        int ret;
 
-       if (!path || !path->num_nodes)
+       if (!path)
                return 0;
 
+       if (WARN_ON(IS_ERR(path) || !path->num_nodes))
+               return -EINVAL;
+
        mutex_lock(&icc_lock);
 
        old_avg = path->reqs[0].avg_bw;