]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net/mlx5: Limit scope of mlx5_get_next_phys_dev() to PCI PF devices
authorParav Pandit <parav@mellanox.com>
Fri, 28 Jun 2019 22:36:02 +0000 (22:36 +0000)
committerSaeed Mahameed <saeedm@mellanox.com>
Mon, 1 Jul 2019 23:40:30 +0000 (16:40 -0700)
As mlx5_get_next_phys_dev is used only for PCI PF devices use case,
limit it to search only for PCI devices.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Vu Pham <vuhuong@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/dev.c

index ebc046fa97d353bce5f9802eb1889faa755bede3..25affce6cbed32a74a1063f9a0ec6f51ba728501 100644 (file)
@@ -290,13 +290,20 @@ static u32 mlx5_gen_pci_id(struct mlx5_core_dev *dev)
 /* Must be called with intf_mutex held */
 struct mlx5_core_dev *mlx5_get_next_phys_dev(struct mlx5_core_dev *dev)
 {
-       u32 pci_id = mlx5_gen_pci_id(dev);
        struct mlx5_core_dev *res = NULL;
        struct mlx5_core_dev *tmp_dev;
        struct mlx5_priv *priv;
+       u32 pci_id;
 
+       if (!mlx5_core_is_pf(dev))
+               return NULL;
+
+       pci_id = mlx5_gen_pci_id(dev);
        list_for_each_entry(priv, &mlx5_dev_list, dev_list) {
                tmp_dev = container_of(priv, struct mlx5_core_dev, priv);
+               if (!mlx5_core_is_pf(tmp_dev))
+                       continue;
+
                if ((dev != tmp_dev) && (mlx5_gen_pci_id(tmp_dev) == pci_id)) {
                        res = tmp_dev;
                        break;