scsi: lpfc: Fix discovery when target has no GID_FT information

Some remote ports may be slow in registering their GID_FT protocol
information with the fabric. If the remote port is an initiator, it may
send PLOGI to the port before the GID_FT logic is complete. Meaning, after
accepting the PLOGI, when the driver may see no response to the GID_FT that
is issued after the login to determine the protocols supported so that
proper PRLI's may be transmit. If the driver has no fc4 information, it
currently stops and the remote port is not discovered.

Fix by issuing a LOGO when there is no GID_FT information.  The LOGO
completion handling will attempt to re-login if the nport_id is still
present.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 3246942ff2ff6cf1de43ab18c9807949666fbaae..c2ac6cb730e8a142df0a033365e7a8153eb16090 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -1215,12 +1215,26 @@ lpfc_cmpl_ct_cmd_gft_id(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
                                         FC_TYPE_FCP, FC_TYPE_NVME,
                                         ndlp->nlp_state);
 
-                       if (ndlp->nlp_state == NLP_STE_REG_LOGIN_ISSUE) {
+                       if (ndlp->nlp_state == NLP_STE_REG_LOGIN_ISSUE &&
+                           ndlp->nlp_fc4_type) {
                                ndlp->nlp_prev_state = NLP_STE_REG_LOGIN_ISSUE;
 
                                lpfc_nlp_set_state(vport, ndlp,
                                                   NLP_STE_PRLI_ISSUE);
                                lpfc_issue_els_prli(vport, ndlp, 0);
+                       } else if (!ndlp->nlp_fc4_type) {
+                               /* If fc4 type is still unknown, then LOGO */
+                               lpfc_printf_vlog(vport, KERN_INFO,
+                                                LOG_DISCOVERY,
+                                                "6443 Sending LOGO ndlp x%px,"
+                                                "DID x%06x with fc4_type: "
+                                                "x%08x, state: %d\n",
+                                                ndlp, did, ndlp->nlp_fc4_type,
+                                                ndlp->nlp_state);
+                               lpfc_issue_els_logo(vport, ndlp, 0);
+                               ndlp->nlp_prev_state = NLP_STE_REG_LOGIN_ISSUE;
+                               lpfc_nlp_set_state(vport, ndlp,
+                                                  NLP_STE_NPR_NODE);
                        }
                }
        } else

diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
index c58000cd744f318cf0e54d1bec1a1e7e6074024f..d76d76081d1a38b552d2498d17e6afea26631ddc 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_nportdisc.c
+++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
@@ -1822,7 +1822,11 @@ lpfc_cmpl_reglogin_reglogin_issue(struct lpfc_vport *vport,
 
                ndlp->nlp_prev_state = NLP_STE_REG_LOGIN_ISSUE;
                lpfc_nlp_set_state(vport, ndlp, NLP_STE_PRLI_ISSUE);
-               lpfc_issue_els_prli(vport, ndlp, 0);
+               if (lpfc_issue_els_prli(vport, ndlp, 0)) {
+                       lpfc_issue_els_logo(vport, ndlp, 0);
+                       ndlp->nlp_prev_state = NLP_STE_REG_LOGIN_ISSUE;
+                       lpfc_nlp_set_state(vport, ndlp, NLP_STE_NPR_NODE);
+               }
        } else {
                if ((vport->fc_flag & FC_PT2PT) && phba->nvmet_support)
                        phba->targetport->port_id = vport->fc_myDID;