]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ARM: dts: realview-pbx: Fix duplicate regulator nodes
authorRob Herring <robh@kernel.org>
Fri, 30 Nov 2018 01:05:47 +0000 (19:05 -0600)
committerOlof Johansson <olof@lixom.net>
Fri, 30 Nov 2018 23:18:47 +0000 (15:18 -0800)
There's a bug in dtc in checking for duplicate node names when there's
another section (e.g. "/ { };"). In this case, skeleton.dtsi provides
another section. Upon removal of skeleton.dtsi, the dtb fails to build
due to a duplicate node 'fixedregulator@0'. As both nodes were pretty
much the same 3.3V fixed regulator, it hasn't really mattered. Fix this
by renaming the nodes to something unique. In the process, drop the
unit-address which shouldn't be present wtihout reg property.

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Olof Johansson <olof@lixom.net>
arch/arm/boot/dts/arm-realview-pbx.dtsi

index a5676697ff3b7dee101d3f56e92379bc6c6b3e64..916a97734f84cc7b72d7087d09e429020c8c957c 100644 (file)
@@ -44,7 +44,7 @@ memory {
        };
 
        /* The voltage to the MMC card is hardwired at 3.3V */
-       vmmc: fixedregulator@0 {
+       vmmc: regulator-vmmc {
                compatible = "regulator-fixed";
                regulator-name = "vmmc";
                regulator-min-microvolt = <3300000>;
@@ -52,7 +52,7 @@ vmmc: fixedregulator@0 {
                regulator-boot-on;
         };
 
-       veth: fixedregulator@0 {
+       veth: regulator-veth {
                compatible = "regulator-fixed";
                regulator-name = "veth";
                regulator-min-microvolt = <3300000>;
@@ -567,4 +567,3 @@ clcd_pads: endpoint {
                };
        };
 };
-