]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/vmwgfx: constify pci_device_id.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Sat, 15 Jul 2017 07:14:53 +0000 (12:44 +0530)
committerSinclair Yeh <syeh@vmware.com>
Tue, 18 Jul 2017 06:41:22 +0000 (23:41 -0700)
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
  13765     800      20   14585    38f9 gpu/drm/vmwgfx/vmwgfx_drv.o

File size After adding 'const':
   text    data     bss     dec     hex filename
  13829     736      20   14585    38f9 gpu/drm/vmwgfx/vmwgfx_drv.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

index ca0ef6972f966ae41e79ab3340501956f74552f2..4436d53ae16c7da1e15769e446015c69f6495995 100644 (file)
@@ -227,7 +227,7 @@ static const struct drm_ioctl_desc vmw_ioctls[] = {
                      DRM_AUTH | DRM_RENDER_ALLOW),
 };
 
-static struct pci_device_id vmw_pci_id_list[] = {
+static const struct pci_device_id vmw_pci_id_list[] = {
        {0x15ad, 0x0405, PCI_ANY_ID, PCI_ANY_ID, 0, 0, VMWGFX_CHIP_SVGAII},
        {0, 0, 0}
 };