]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
arch_topology: Change return type of topology_parse_cpu_capacity() to bool
authorViresh Kumar <viresh.kumar@linaro.org>
Fri, 23 Jun 2017 09:25:32 +0000 (14:55 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Jul 2017 15:32:05 +0000 (17:32 +0200)
topology_parse_cpu_capacity() returns 1 on success and 0 on errors. Make
it return bool instead of int as that suits the purpose better.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Juri Lelli <juri.lelli@arm.com>
Tested-by: Juri Lelli <juri.lelli@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/arch_topology.c
include/linux/arch_topology.h

index a3cd7c869c3ee95e3ac270362f118a313a7e76e0..5728e2fbb7658098ac30d079720618b0c190e3b5 100644 (file)
@@ -119,13 +119,13 @@ void topology_normalize_cpu_scale(void)
        mutex_unlock(&cpu_scale_mutex);
 }
 
-int __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu)
+bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu)
 {
-       int ret = 1;
+       int ret;
        u32 cpu_capacity;
 
        if (cap_parsing_failed)
-               return !ret;
+               return false;
 
        ret = of_property_read_u32(cpu_node, "capacity-dmips-mhz",
                                   &cpu_capacity);
@@ -137,7 +137,7 @@ int __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu)
                        if (!raw_capacity) {
                                pr_err("cpu_capacity: failed to allocate memory for raw capacities\n");
                                cap_parsing_failed = true;
-                               return 0;
+                               return false;
                        }
                }
                capacity_scale = max(cpu_capacity, capacity_scale);
index 9af3c174c03aa543dd3ced0905cc6cdb3b662c92..716ce587247e0b2b503969ee1ca2f1c090942eaa 100644 (file)
@@ -4,10 +4,12 @@
 #ifndef _LINUX_ARCH_TOPOLOGY_H_
 #define _LINUX_ARCH_TOPOLOGY_H_
 
+#include <linux/types.h>
+
 void topology_normalize_cpu_scale(void);
 
 struct device_node;
-int topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu);
+bool topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu);
 
 struct sched_domain;
 unsigned long topology_get_cpu_scale(struct sched_domain *sd, int cpu);