]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: mtk-vcodec: Remove extra area allocation in an input buffer on encoding
authorHirokazu Honda <hiroh@chromium.org>
Thu, 7 Nov 2019 03:30:57 +0000 (04:30 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Dec 2019 09:19:42 +0000 (10:19 +0100)
MediaTek encoder allocates non pixel data area for an input buffer every
plane. As the input buffer should be read-only, the driver should not write
anything in the buffer. Therefore, the extra data should be unnecessary.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c

index fd8de027e83e30a2b5fd7b3afc866dbb1e1f5426..6aad53d97d74ae75b3f362a1495946184a626d39 100644 (file)
@@ -332,14 +332,12 @@ static int vidioc_try_fmt(struct v4l2_format *f,
 
                pix_fmt_mp->num_planes = fmt->num_planes;
                pix_fmt_mp->plane_fmt[0].sizeimage =
-                               pix_fmt_mp->width * pix_fmt_mp->height +
-                               ((ALIGN(pix_fmt_mp->width, 16) * 2) * 16);
+                       pix_fmt_mp->width * pix_fmt_mp->height;
                pix_fmt_mp->plane_fmt[0].bytesperline = pix_fmt_mp->width;
 
                if (pix_fmt_mp->num_planes == 2) {
                        pix_fmt_mp->plane_fmt[1].sizeimage =
-                               (pix_fmt_mp->width * pix_fmt_mp->height) / 2 +
-                               (ALIGN(pix_fmt_mp->width, 16) * 16);
+                               (pix_fmt_mp->width * pix_fmt_mp->height) / 2;
                        pix_fmt_mp->plane_fmt[2].sizeimage = 0;
                        pix_fmt_mp->plane_fmt[1].bytesperline =
                                                        pix_fmt_mp->width;
@@ -347,8 +345,7 @@ static int vidioc_try_fmt(struct v4l2_format *f,
                } else if (pix_fmt_mp->num_planes == 3) {
                        pix_fmt_mp->plane_fmt[1].sizeimage =
                        pix_fmt_mp->plane_fmt[2].sizeimage =
-                               (pix_fmt_mp->width * pix_fmt_mp->height) / 4 +
-                               ((ALIGN(pix_fmt_mp->width, 16) / 2) * 16);
+                               (pix_fmt_mp->width * pix_fmt_mp->height) / 4;
                        pix_fmt_mp->plane_fmt[1].bytesperline =
                                pix_fmt_mp->plane_fmt[2].bytesperline =
                                pix_fmt_mp->width / 2;