]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
powerpc/pmu/fsl: fix is_nmi test for irq mask change
authorNicholas Piggin <npiggin@gmail.com>
Thu, 10 May 2018 01:04:23 +0000 (11:04 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Sun, 3 Jun 2018 10:40:29 +0000 (20:40 +1000)
When soft enabled was changed to irq disabled mask, this test missed
being converted (although the equivalent book3s test was converted).

The PMU drivers consider it an NMI when they take a PMI while general
interrupts are disabled. This change restores that behaviour.

Fixes: 01417c6cc7 ("powerpc/64: Change soft_enabled from flag to bitmask")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/perf/core-fsl-emb.c

index 85f1d18e5fd3099c9d810eb5c5e6211bd144c959..ba485844d506cd7ad415655e031ad8d096baf1ae 100644 (file)
@@ -42,7 +42,7 @@ static DEFINE_MUTEX(pmc_reserve_mutex);
 static inline int perf_intr_is_nmi(struct pt_regs *regs)
 {
 #ifdef __powerpc64__
-       return !regs->softe;
+       return (regs->softe & IRQS_DISABLED);
 #else
        return 0;
 #endif