]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
io_uring: remove unnecessary barrier before reading SQ tail
authorStefan Bühler <source@stbuehler.de>
Wed, 24 Apr 2019 21:54:20 +0000 (23:54 +0200)
committerJens Axboe <axboe@kernel.dk>
Tue, 30 Apr 2019 15:40:02 +0000 (09:40 -0600)
There is no operation before to order with.

Signed-off-by: Stefan Bühler <source@stbuehler.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index d3c57ee233fe78d5f64e600a0e5c8019306b5292..662f1c070c8cc1d5693c028ebe6816c72d4bdd4d 100644 (file)
@@ -1831,8 +1831,6 @@ static bool io_get_sqring(struct io_ring_ctx *ctx, struct sqe_submit *s)
         *    though the application is the one updating it.
         */
        head = ctx->cached_sq_head;
-       /* See comment at the top of this file */
-       smp_rmb();
        /* make sure SQ entry isn't read before tail */
        if (head == smp_load_acquire(&ring->r.tail))
                return false;