]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: omap3isp: Check for valid port in endpoints
authorSakari Ailus <sakari.ailus@linux.intel.com>
Tue, 28 Feb 2017 12:38:44 +0000 (07:38 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 19 Jul 2017 19:45:14 +0000 (15:45 -0400)
Check that we do have a valid port in an endpoint, return an error if not.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Tested-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/omap3isp/isp.c

index 9df64c18988389b3818b67c1dc2f4014156295e7..40d1a200be32d80ad85c853d5cc39b87c21d0153 100644 (file)
@@ -2080,7 +2080,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode,
        default:
                dev_warn(dev, "%s: invalid interface %u\n",
                         to_of_node(fwnode)->full_name, vep.base.port);
-               break;
+               return -EINVAL;
        }
 
        return 0;