pinctrl: pic32: Pass irqchip when adding gpiochip

We need to convert all old gpio irqchips to pass the irqchip
setup along when adding the gpio_chip. For more info see
drivers/gpio/TODO.

For chained irqchips this is a pretty straight-forward
conversion.

Cc: Joshua Henderson <joshua.henderson@microchip.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20190913113530.5536-2-linus.walleij@linaro.org

diff --git a/drivers/pinctrl/pinctrl-pic32.c b/drivers/pinctrl/pinctrl-pic32.c
index e7f6dd5ab57848fdd8417f05444091f677d2758d..7e4c5a08a932098d1a7be3c254b947935ae2e190 100644 (file)
--- a/drivers/pinctrl/pinctrl-pic32.c
+++ b/drivers/pinctrl/pinctrl-pic32.c
@@ -2203,6 +2203,7 @@ static int pic32_gpio_probe(struct platform_device *pdev)
        u32 id;
        int irq, ret;
        struct resource *res;
+       struct gpio_irq_chip *girq;
 
        if (of_property_read_u32(np, "microchip,gpio-bank", &id)) {
                dev_err(&pdev->dev, "microchip,gpio-bank property not found\n");
@@ -2240,25 +2241,23 @@ static int pic32_gpio_probe(struct platform_device *pdev)
 
        bank->gpio_chip.parent = &pdev->dev;
        bank->gpio_chip.of_node = np;
+       girq = &bank->gpio_chip.irq;
+       girq->chip = &bank->irq_chip;
+       girq->parent_handler = pic32_gpio_irq_handler;
+       girq->num_parents = 1;
+       girq->parents = devm_kcalloc(&pdev->dev, 1, sizeof(*girq->parents),
+                                    GFP_KERNEL);
+       if (!girq->parents)
+               return -ENOMEM;
+       girq->default_type = IRQ_TYPE_NONE;
+       girq->handler = handle_level_irq;
+       girq->parents[0] = irq;
        ret = gpiochip_add_data(&bank->gpio_chip, bank);
        if (ret < 0) {
                dev_err(&pdev->dev, "Failed to add GPIO chip %u: %d\n",
                        id, ret);
                return ret;
        }
-
-       ret = gpiochip_irqchip_add(&bank->gpio_chip, &bank->irq_chip,
-                               0, handle_level_irq, IRQ_TYPE_NONE);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "Failed to add IRQ chip %u: %d\n",
-                       id, ret);
-               gpiochip_remove(&bank->gpio_chip);
-               return ret;
-       }
-
-       gpiochip_set_chained_irqchip(&bank->gpio_chip, &bank->irq_chip,
-                                    irq, pic32_gpio_irq_handler);
-
        return 0;
 }