]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
i2c: designware: Don't use internal ___constant_swab32
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Tue, 19 Jun 2018 11:23:20 +0000 (14:23 +0300)
committerWolfram Sang <wsa@the-dreams.de>
Tue, 3 Jul 2018 21:05:27 +0000 (23:05 +0200)
It looks ___constant_swab32 is an internal byte swap detail. Switch to
swap32() and include header file for it explicitly. Now it comes
implicitly via linux/i2c.h include.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-designware-common.c

index d1c93acabfcfc858f230d85e4c6c62b201e10dd4..59156046f2d0afeeff1fd58d8037e5c0221f51cf 100644 (file)
@@ -31,6 +31,7 @@
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/pm_runtime.h>
+#include <linux/swab.h>
 
 #include "i2c-designware-core.h"
 
@@ -113,7 +114,7 @@ int i2c_dw_set_reg_access(struct dw_i2c_dev *dev)
        reg = dw_readl(dev, DW_IC_COMP_TYPE);
        i2c_dw_release_lock(dev);
 
-       if (reg == ___constant_swab32(DW_IC_COMP_TYPE_VALUE)) {
+       if (reg == swab32(DW_IC_COMP_TYPE_VALUE)) {
                /* Configure register endianess access */
                dev->flags |= ACCESS_SWAP;
        } else if (reg == (DW_IC_COMP_TYPE_VALUE & 0x0000ffff)) {