]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: wlan-ng: Remove function hfa384x_dowrid_wait()
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Fri, 12 Jul 2019 06:27:59 +0000 (11:57 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Jul 2019 05:34:11 +0000 (07:34 +0200)
Remove inline function hfa384x_dowrid_wait as it is only called once (in
hfa384x_drvr_setconfig) and its contents are only a single line (a call
to hfa384x_dowrid).
Replace the call to hfa384x_dowrid_wait with its contents i.e the call
to hfa384x_dowrid.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190712062807.9361-2-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/hfa384x_usb.c

index 4befc615d8e293ad4a888d7c2226e7f676971c6a..dc6abc6541658368e07124294db895582f1220b5 100644 (file)
@@ -845,14 +845,6 @@ hfa384x_dorrid_async(struct hfa384x *hw,
                              cmdcb, usercb, usercb_data);
 }
 
-static inline int
-hfa384x_dowrid_wait(struct hfa384x *hw, u16 rid, void *riddata,
-                   unsigned int riddatalen)
-{
-       return hfa384x_dowrid(hw, DOWAIT,
-                             rid, riddata, riddatalen, NULL, NULL, NULL);
-}
-
 static inline int
 hfa384x_dowrid_async(struct hfa384x *hw,
                     u16 rid, void *riddata, unsigned int riddatalen,
@@ -2414,7 +2406,7 @@ int hfa384x_drvr_readpda(struct hfa384x *hw, void *buf, unsigned int len)
  */
 int hfa384x_drvr_setconfig(struct hfa384x *hw, u16 rid, void *buf, u16 len)
 {
-       return hfa384x_dowrid_wait(hw, rid, buf, len);
+       return hfa384x_dowrid(hw, DOWAIT, rid, buf, len, NULL, NULL, NULL);
 }
 
 /*----------------------------------------------------------------