]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
PCI: rcar: Handle rcar_pcie_parse_request_of_pci_ranges() failures
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 7 Dec 2017 10:15:20 +0000 (11:15 +0100)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Tue, 19 Dec 2017 11:25:43 +0000 (11:25 +0000)
rcar_pcie_parse_request_of_pci_ranges() can fail and return an error
code, but this is not checked nor handled.

Fix this by adding the missing error handling.

Fixes: 5d2917d469faab72 ("PCI: rcar: Convert to DT resource parsing API")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/host/pcie-rcar.c

index 52ab3cb0a0bfe065d8209201cbf03a7ef15cdfa4..95ca4a1feba4b7593f16447518b9266205546e0f 100644 (file)
@@ -1123,7 +1123,9 @@ static int rcar_pcie_probe(struct platform_device *pdev)
 
        INIT_LIST_HEAD(&pcie->resources);
 
-       rcar_pcie_parse_request_of_pci_ranges(pcie);
+       err = rcar_pcie_parse_request_of_pci_ranges(pcie);
+       if (err)
+               goto err_free_bridge;
 
        err = rcar_pcie_get_resources(pcie);
        if (err < 0) {
@@ -1178,6 +1180,7 @@ static int rcar_pcie_probe(struct platform_device *pdev)
 
 err_free_resource_list:
        pci_free_resource_list(&pcie->resources);
+err_free_bridge:
        pci_free_host_bridge(bridge);
 
        return err;