]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/modes: parse_cmdline: Make various char pointers const
authorHans de Goede <hdegoede@redhat.com>
Mon, 18 Nov 2019 15:51:23 +0000 (16:51 +0100)
committerHans de Goede <hdegoede@redhat.com>
Mon, 16 Dec 2019 11:13:17 +0000 (12:13 +0100)
We are not supposed to modify the passed in string, make char pointers
used in drm_mode_parse_cmdline_options() const char * where possible.

Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191118155134.30468-2-hdegoede@redhat.com
drivers/gpu/drm/drm_modes.c

index 3c3c7435225f77e1cf8041fda0c50ab40a31c43c..654d4b6fecb330dad83ae972d62461b3af2ba8bb 100644 (file)
@@ -1591,15 +1591,15 @@ static int drm_mode_parse_cmdline_int(const char *delim, unsigned int *int_ret)
        return 0;
 }
 
-static int drm_mode_parse_cmdline_options(char *str, size_t len,
+static int drm_mode_parse_cmdline_options(const char *str, size_t len,
                                          const struct drm_connector *connector,
                                          struct drm_cmdline_mode *mode)
 {
        unsigned int deg, margin, rotation = 0;
-       char *sep = str;
+       const char *sep = str;
 
        while ((sep = strchr(sep, ','))) {
-               char *delim, *option;
+               const char *delim, *option;
 
                option = sep + 1;
                delim = strchr(option, '=');
@@ -1718,8 +1718,8 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option,
        bool named_mode = false, parse_extras = false;
        unsigned int bpp_off = 0, refresh_off = 0, options_off = 0;
        unsigned int mode_end = 0;
-       char *bpp_ptr = NULL, *refresh_ptr = NULL, *extra_ptr = NULL;
-       char *options_ptr = NULL;
+       const char *bpp_ptr = NULL, *refresh_ptr = NULL, *extra_ptr = NULL;
+       const char *options_ptr = NULL;
        char *bpp_end_ptr = NULL, *refresh_end_ptr = NULL;
        int ret;