]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
misc: pci_endpoint_test: Avoid triggering a BUG()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 30 Sep 2017 08:16:51 +0000 (11:16 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Oct 2017 08:39:28 +0000 (10:39 +0200)
If you call ida_simple_remove(&pci_endpoint_test_ida, id) with a
negative "id" then it triggers an immediate BUG_ON().  Let's not allow
that.

Fixes: 2c156ac71c6b ("misc: Add host side PCI driver for PCI test function device")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/pci_endpoint_test.c

index c0d323077ad0deebe78f21fd3738d4d6a005df95..d40a34f594c7cf2698aca7d3bbaa076bd742da3d 100644 (file)
@@ -597,6 +597,8 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev)
 
        if (sscanf(misc_device->name, DRV_MODULE_NAME ".%d", &id) != 1)
                return;
+       if (id < 0)
+               return;
 
        misc_deregister(&test->miscdev);
        ida_simple_remove(&pci_endpoint_test_ida, id);