]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
isdn: hisax: Fix pnp_irq's error checking for setup_asuscom
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 16 Nov 2017 04:27:18 +0000 (09:57 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Nov 2017 13:31:15 +0000 (22:31 +0900)
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/asuscom.c

index 62f9c43e2377b0cfb9c3f9771d019b588033c898..74c871495e814ac1f0a7c4cfa5906a8381305dc5 100644 (file)
@@ -348,7 +348,7 @@ int setup_asuscom(struct IsdnCard *card)
                                        }
                                        card->para[1] = pnp_port_start(pnp_d, 0);
                                        card->para[0] = pnp_irq(pnp_d, 0);
-                                       if (!card->para[0] || !card->para[1]) {
+                                       if (card->para[0] == -1 || !card->para[1]) {
                                                printk(KERN_ERR "AsusPnP:some resources are missing %ld/%lx\n",
                                                       card->para[0], card->para[1]);
                                                pnp_disable_dev(pnp_d);