]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: smd845: fix memory leak
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 3 Aug 2018 13:42:11 +0000 (08:42 -0500)
committerMark Brown <broonie@kernel.org>
Fri, 3 Aug 2018 14:46:34 +0000 (15:46 +0100)
In case memory resources for *card* were allocated, release them before
return.

Addresses-Coverity-ID: 1472244 ("Resource leak")
Fixes: 6b1687bf76ef ("ASoC: qcom: add sdm845 sound card support")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/sdm845.c

index be0cb11220365f8e369d682a45de14bbf14da5da..c1adb77230ebedf1a77b5b6b204f7dee1ef2c265 100644 (file)
@@ -222,8 +222,10 @@ static int sdm845_snd_platform_probe(struct platform_device *pdev)
 
        /* Allocate the private data */
        data = kzalloc(sizeof(*data), GFP_KERNEL);
-       if (!data)
-               return -ENOMEM;
+       if (!data) {
+               ret = -ENOMEM;
+               goto data_alloc_fail;
+       }
 
        card->dev = dev;
        dev_set_drvdata(dev, card);
@@ -248,6 +250,7 @@ static int sdm845_snd_platform_probe(struct platform_device *pdev)
        kfree(card->dai_link);
 parse_dt_fail:
        kfree(data);
+data_alloc_fail:
        kfree(card);
        return ret;
 }