]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: omap-mcpdm: Mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 3 Aug 2018 16:32:52 +0000 (11:32 -0500)
committerMark Brown <broonie@kernel.org>
Fri, 3 Aug 2018 16:42:32 +0000 (17:42 +0100)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1369526 ("Missing break in switch")
Addresses-Coverity-ID: 1369529 ("Missing break in switch")
Addresses-Coverity-ID: 1451415 ("Missing break in switch")
Addresses-Coverity-ID: 115103 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/omap/omap-mcpdm.c

index 0e97360f9890980ce9e069e99c1a04a975986033..4c1be36c22075b3b449325dfc44eccd565c50f1a 100644 (file)
@@ -310,15 +310,19 @@ static int omap_mcpdm_dai_hw_params(struct snd_pcm_substream *substream,
                        /* up to 3 channels for capture */
                        return -EINVAL;
                link_mask |= 1 << 4;
+               /* fall through */
        case 4:
                if (stream == SNDRV_PCM_STREAM_CAPTURE)
                        /* up to 3 channels for capture */
                        return -EINVAL;
                link_mask |= 1 << 3;
+               /* fall through */
        case 3:
                link_mask |= 1 << 2;
+               /* fall through */
        case 2:
                link_mask |= 1 << 1;
+               /* fall through */
        case 1:
                link_mask |= 1 << 0;
                break;