]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
HID: roccat: silence an uninitialized variable warning
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 2 Apr 2016 04:44:32 +0000 (07:44 +0300)
committerJiri Kosina <jkosina@suse.cz>
Mon, 4 Apr 2016 07:49:12 +0000 (09:49 +0200)
My static checker complains because we use "dev_id" before we check for
errors so it could be uninitialized.  Fix this by moving the error
handling forward a couple lines.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-roccat.c

index 65c4ccfcbd2941994b7778fdbde661c60005c4d6..76d06cf87b2ac31958d238d7bd0254bf02032fda 100644 (file)
@@ -421,14 +421,13 @@ static int __init roccat_init(void)
 
        retval = alloc_chrdev_region(&dev_id, ROCCAT_FIRST_MINOR,
                        ROCCAT_MAX_DEVICES, "roccat");
-
-       roccat_major = MAJOR(dev_id);
-
        if (retval < 0) {
                pr_warn("can't get major number\n");
                goto error;
        }
 
+       roccat_major = MAJOR(dev_id);
+
        cdev_init(&roccat_cdev, &roccat_ops);
        retval = cdev_add(&roccat_cdev, dev_id, ROCCAT_MAX_DEVICES);