]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: cx18: Drop superfluous ioctl PCM ops
authorTakashi Iwai <tiwai@suse.de>
Tue, 10 Dec 2019 13:58:47 +0000 (14:58 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 13 Dec 2019 08:33:14 +0000 (09:33 +0100)
snd_cx18_pcm_ioctl() does nothing but calling the default handler.
Now PCM core accepts NULL as the default ioctl ops, so let's drop
altogether.

Cc: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/cx18/cx18-alsa-pcm.c

index 7dec5ce20eb7090a0360956fbffa6454eecf5557..bed28b4b41f74bd9124f3a1f0a37116e38cce7da 100644 (file)
@@ -200,18 +200,6 @@ static int snd_cx18_pcm_capture_close(struct snd_pcm_substream *substream)
        return 0;
 }
 
-static int snd_cx18_pcm_ioctl(struct snd_pcm_substream *substream,
-                    unsigned int cmd, void *arg)
-{
-       struct snd_cx18_card *cxsc = snd_pcm_substream_chip(substream);
-       int ret;
-
-       snd_cx18_lock(cxsc);
-       ret = snd_pcm_lib_ioctl(substream, cmd, arg);
-       snd_cx18_unlock(cxsc);
-       return ret;
-}
-
 static int snd_cx18_pcm_prepare(struct snd_pcm_substream *substream)
 {
        struct snd_cx18_card *cxsc = snd_pcm_substream_chip(substream);
@@ -244,7 +232,6 @@ snd_pcm_uframes_t snd_cx18_pcm_pointer(struct snd_pcm_substream *substream)
 static const struct snd_pcm_ops snd_cx18_pcm_capture_ops = {
        .open           = snd_cx18_pcm_capture_open,
        .close          = snd_cx18_pcm_capture_close,
-       .ioctl          = snd_cx18_pcm_ioctl,
        .prepare        = snd_cx18_pcm_prepare,
        .trigger        = snd_cx18_pcm_trigger,
        .pointer        = snd_cx18_pcm_pointer,