]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
gve: Fix error return code in gve_alloc_qpls()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 5 Jul 2019 01:16:42 +0000 (01:16 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Jul 2019 02:25:36 +0000 (19:25 -0700)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/google/gve/gve_main.c

index eef500bd2ff7283463e671e9382e677976a30d31..24f16e3368cda1585c515be82dd229598e24a89b 100644 (file)
@@ -625,8 +625,10 @@ static int gve_alloc_qpls(struct gve_priv *priv)
                                     sizeof(unsigned long) * BITS_PER_BYTE;
        priv->qpl_cfg.qpl_id_map = kvzalloc(BITS_TO_LONGS(num_qpls) *
                                            sizeof(unsigned long), GFP_KERNEL);
-       if (!priv->qpl_cfg.qpl_id_map)
+       if (!priv->qpl_cfg.qpl_id_map) {
+               err = -ENOMEM;
                goto free_qpls;
+       }
 
        return 0;