]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: vc04_services: Remove VCHIQ_QUEUE_MESSAGE_T typedef
authorDominic Braun <inf.braun@fau.de>
Fri, 14 Dec 2018 12:04:59 +0000 (13:04 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 13:46:22 +0000 (14:46 +0100)
Typedefing structs is not encouraged in the kernel.

Signed-off-by: Dominic Braun <inf.braun@fau.de>
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h

index f2c871f8c0ffa4c7e16633dad16192c8fa8bcb86..13985501a8c0c38b6f83ba5672dec862eac012cf 100644 (file)
@@ -1040,7 +1040,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        } break;
 
        case VCHIQ_IOC_QUEUE_MESSAGE: {
-               VCHIQ_QUEUE_MESSAGE_T args;
+               struct vchiq_queue_message args;
 
                if (copy_from_user
                         (&args, (const void __user *)arg,
@@ -1593,7 +1593,7 @@ vchiq_compat_ioctl_queue_message(struct file *file,
                                 unsigned int cmd,
                                 unsigned long arg)
 {
-       VCHIQ_QUEUE_MESSAGE_T *args;
+       struct vchiq_queue_message *args;
        struct vchiq_element __user *elements;
        struct vchiq_queue_message32 args32;
        unsigned int count;
index 284ce4faa384fdcaa23ed47cac3ef3da78adfb0d..9e21d1c472dea9639c124aa2b3eb463200573554 100644 (file)
@@ -47,11 +47,11 @@ struct vchiq_create_service {
        unsigned int handle;       /* OUT */
 };
 
-typedef struct {
+struct vchiq_queue_message {
        unsigned int handle;
        unsigned int count;
        const struct vchiq_element __user *elements;
-} VCHIQ_QUEUE_MESSAGE_T;
+};
 
 struct vchiq_queue_bulk_transfer {
        unsigned int handle;
@@ -105,7 +105,7 @@ struct vchiq_dump_mem {
        _IOWR(VCHIQ_IOC_MAGIC, 2, struct vchiq_create_service)
 #define VCHIQ_IOC_REMOVE_SERVICE       _IO(VCHIQ_IOC_MAGIC,   3)
 #define VCHIQ_IOC_QUEUE_MESSAGE \
-       _IOW(VCHIQ_IOC_MAGIC,  4, VCHIQ_QUEUE_MESSAGE_T)
+       _IOW(VCHIQ_IOC_MAGIC,  4, struct vchiq_queue_message)
 #define VCHIQ_IOC_QUEUE_BULK_TRANSMIT \
        _IOWR(VCHIQ_IOC_MAGIC, 5, struct vchiq_queue_bulk_transfer)
 #define VCHIQ_IOC_QUEUE_BULK_RECEIVE \