]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
RDMA/restrack: clean up res_to_dev()
authorSteve Wise <swise@opengridcomputing.com>
Thu, 1 Mar 2018 21:57:22 +0000 (13:57 -0800)
committerDoug Ledford <dledford@redhat.com>
Thu, 8 Mar 2018 20:03:03 +0000 (15:03 -0500)
Simplify res_to_dev() to make it easier to read/maintain.

Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/core/restrack.c

index 3dbc4e4cca415fd94a24443e44d1430a5cbe63d7..41a780085e6d345429e27bc425966855b285868f 100644 (file)
@@ -60,31 +60,17 @@ static void set_kern_name(struct rdma_restrack_entry *res)
 
 static struct ib_device *res_to_dev(struct rdma_restrack_entry *res)
 {
-       enum rdma_restrack_type type = res->type;
-       struct ib_device *dev;
-       struct ib_pd *pd;
-       struct ib_cq *cq;
-       struct ib_qp *qp;
-
-       switch (type) {
+       switch (res->type) {
        case RDMA_RESTRACK_PD:
-               pd = container_of(res, struct ib_pd, res);
-               dev = pd->device;
-               break;
+               return container_of(res, struct ib_pd, res)->device;
        case RDMA_RESTRACK_CQ:
-               cq = container_of(res, struct ib_cq, res);
-               dev = cq->device;
-               break;
+               return container_of(res, struct ib_cq, res)->device;
        case RDMA_RESTRACK_QP:
-               qp = container_of(res, struct ib_qp, res);
-               dev = qp->device;
-               break;
+               return container_of(res, struct ib_qp, res)->device;
        default:
-               WARN_ONCE(true, "Wrong resource tracking type %u\n", type);
+               WARN_ONCE(true, "Wrong resource tracking type %u\n", res->type);
                return NULL;
        }
-
-       return dev;
 }
 
 static bool res_is_user(struct rdma_restrack_entry *res)