]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: rt5645: rename jd_invert flag in platform data
authorBard Liao <bardliao@realtek.com>
Wed, 28 Jun 2017 12:49:37 +0000 (14:49 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 28 Jun 2017 17:33:31 +0000 (18:33 +0100)
The jd_invert flag is actually used for level triggered IRQ. Rename
it to let code more readable.

Signed-off-by: Bard Liao <bardliao@realtek.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/rt5645.h
sound/soc/codecs/rt5645.c

index a5cf6152e778929d572250462b2252a4369b08ca..c427f10a39aeb1fe12b0c12f70b3908e74d8b8ec 100644 (file)
@@ -21,8 +21,8 @@ struct rt5645_platform_data {
        /* 0 = IN2P; 1 = GPIO6; 2 = GPIO10; 3 = GPIO12 */
 
        unsigned int jd_mode;
-       /* Invert JD when jack insert */
-       bool jd_invert;
+       /* Use level triggered irq */
+       bool level_trigger_irq;
 };
 
 #endif
index 8e419ea418e95cb74de56347dc209711c83baaee..e0c09bbd3f12218a0e5a3f4a90279bf54dd1533c 100644 (file)
@@ -3151,7 +3151,7 @@ static int rt5645_jack_detect(struct snd_soc_codec *codec, int jack_insert)
                        snd_soc_dapm_sync(dapm);
                        rt5645->jack_type = SND_JACK_HEADPHONE;
                }
-               if (rt5645->pdata.jd_invert)
+               if (rt5645->pdata.level_trigger_irq)
                        regmap_update_bits(rt5645->regmap, RT5645_IRQ_CTRL2,
                                RT5645_JD_1_1_MASK, RT5645_JD_1_1_NOR);
        } else { /* jack out */
@@ -3172,7 +3172,7 @@ static int rt5645_jack_detect(struct snd_soc_codec *codec, int jack_insert)
                        snd_soc_dapm_disable_pin(dapm, "LDO2");
                snd_soc_dapm_disable_pin(dapm, "Mic Det Power");
                snd_soc_dapm_sync(dapm);
-               if (rt5645->pdata.jd_invert)
+               if (rt5645->pdata.level_trigger_irq)
                        regmap_update_bits(rt5645->regmap, RT5645_IRQ_CTRL2,
                                RT5645_JD_1_1_MASK, RT5645_JD_1_1_INV);
        }
@@ -3586,7 +3586,7 @@ static struct rt5645_platform_data buddy_platform_data = {
        .dmic1_data_pin = RT5645_DMIC_DATA_GPIO5,
        .dmic2_data_pin = RT5645_DMIC_DATA_IN2P,
        .jd_mode = 3,
-       .jd_invert = true,
+       .level_trigger_irq = true,
 };
 
 static struct dmi_system_id dmi_platform_intel_broadwell[] = {
@@ -3838,7 +3838,7 @@ static int rt5645_i2c_probe(struct i2c_client *i2c,
        regmap_update_bits(rt5645->regmap, RT5645_ADDA_CLK1,
                RT5645_I2S_PD1_MASK, RT5645_I2S_PD1_2);
 
-       if (rt5645->pdata.jd_invert) {
+       if (rt5645->pdata.level_trigger_irq) {
                regmap_update_bits(rt5645->regmap, RT5645_IRQ_CTRL2,
                        RT5645_JD_1_1_MASK, RT5645_JD_1_1_INV);
        }