]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
coresight: etm4x: improve clarity of etm4_os_unlock comment
authorAndrew Murray <andrew.murray@arm.com>
Thu, 29 Aug 2019 20:28:37 +0000 (14:28 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Sep 2019 20:01:17 +0000 (22:01 +0200)
To improve clarity, let's update the comment for etm4_os_unlock
to use the name of the register as per the ETM architecture
specification.

The existing comment is also misleading as it suggests any value
written to TRCOSLAR unlocks the trace registers, however it must
be '0' - let's also correct this.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20190829202842.580-13-mathieu.poirier@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/coresight/coresight-etm4x.c

index 615bdbf7c9b7ea817a6f84b5273314026481fd52..a128b5063f46c9571b7076bd478c3f344f65a052 100644 (file)
@@ -48,7 +48,7 @@ static enum cpuhp_state hp_online;
 
 static void etm4_os_unlock(struct etmv4_drvdata *drvdata)
 {
-       /* Writing any value to ETMOSLAR unlocks the trace registers */
+       /* Writing 0 to TRCOSLAR unlocks the trace registers */
        writel_relaxed(0x0, drvdata->base + TRCOSLAR);
        drvdata->os_unlock = true;
        isb();