]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
lib/cmdline.c: mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 25 Jan 2019 20:25:24 +0000 (14:25 -0600)
committerGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 8 Apr 2019 23:39:23 +0000 (18:39 -0500)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warnings:

lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.

Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
lib/cmdline.c

index 171c19b6888e207bd663e9e41a87c7b0fad9a1de..dc59d62163181abcc1bb4b7b66f385e11d728d1c 100644 (file)
@@ -135,18 +135,23 @@ unsigned long long memparse(const char *ptr, char **retptr)
        case 'E':
        case 'e':
                ret <<= 10;
+               /* fall through */
        case 'P':
        case 'p':
                ret <<= 10;
+               /* fall through */
        case 'T':
        case 't':
                ret <<= 10;
+               /* fall through */
        case 'G':
        case 'g':
                ret <<= 10;
+               /* fall through */
        case 'M':
        case 'm':
                ret <<= 10;
+               /* fall through */
        case 'K':
        case 'k':
                ret <<= 10;