]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
wimax: usb-tx: mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 9 Aug 2018 15:47:20 +0000 (10:47 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sat, 11 Aug 2018 18:29:36 +0000 (11:29 -0700)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I placed the "fall through"
annotation at the bottom of the case, which is what GCC is expecting
to find.

Addresses-Coverity-ID: 115075 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wimax/i2400m/usb-tx.c

index 99ef81b3d5a515d6cc4ae6f176514ceca3e2942d..3a0e7226768ade6ee33081ee04d6f90de734c2a2 100644 (file)
@@ -131,12 +131,12 @@ int i2400mu_tx(struct i2400mu *i2400mu, struct i2400m_msg_hdr *tx_msg,
                        dev_err(dev, "BM-CMD: too many stalls in "
                                "URB; resetting device\n");
                        usb_queue_reset_device(i2400mu->usb_iface);
-                       /* fallthrough */
                } else {
                        usb_clear_halt(i2400mu->usb_dev, usb_pipe);
                        msleep(10);     /* give the device some time */
                        goto retry;
                }
+               /* fall through */
        case -EINVAL:                   /* while removing driver */
        case -ENODEV:                   /* dev disconnect ... */
        case -ENOENT:                   /* just ignore it */