]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/omapdrm: drop fb_debug_enter/leave
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 14 Jun 2019 20:35:24 +0000 (22:35 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 21 Jun 2019 15:30:49 +0000 (17:30 +0200)
This is a no-op on atomic drivers because with atomic it's simply too
complicated to get all the locking and workers and nonblocking
synchronization correct, from essentially an NMI context. Well, too
complicated = impossible. Also, omapdrm never implemented the
mode_set_base_atomic hook, so I kinda wonder why this was ever added.

Drop the hooks.

Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190614203615.12639-9-daniel.vetter@ffwll.ch
drivers/gpu/drm/omapdrm/omap_fbdev.c

index 50aabd854f4dfff3c5df4044a00cd275fefcadd6..0dad42e819ba8edf4eba61a566920805f9ab6811 100644 (file)
@@ -87,8 +87,6 @@ static struct fb_ops omap_fb_ops = {
        .fb_setcmap     = drm_fb_helper_setcmap,
        .fb_blank       = drm_fb_helper_blank,
        .fb_pan_display = omap_fbdev_pan_display,
-       .fb_debug_enter = drm_fb_helper_debug_enter,
-       .fb_debug_leave = drm_fb_helper_debug_leave,
        .fb_ioctl       = drm_fb_helper_ioctl,
 
        .fb_read = drm_fb_helper_sys_read,