]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
spi: pxa2xxx: change "no DMA channels..." msg from debug to warning
authorFlavio Suligoi <f.suligoi@asem.it>
Fri, 5 Apr 2019 12:40:22 +0000 (14:40 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 8 Apr 2019 07:09:27 +0000 (14:09 +0700)
Change the type of the diagnostic message:

"no DMA channels available, using PIO"

from debug to warning.

The lack of an available DMA channel is very important regard the
spi-pxa2xx performance. The transfer speed can be reduced more than 50%.

So it is very important to warn the user about this, without enabling
the full SPI debug with CONFIG_SPI_DEBUG.

Moreover, enabling the full SPI debug only to enable this specific
debug message, the dmesg buffer fills quickly with a lot of
repetitive information during the SPI data transfer.
This cause the loss of all the first important messages
written during the initialization.

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx.c

index 6160fe0ce7ab675714f011e7286c0b8fdb83b9e4..f7068ccfe7d2868f2204bb26806a45cda295b4a6 100644 (file)
@@ -1696,7 +1696,7 @@ static int pxa2xx_spi_probe(struct platform_device *pdev)
        if (platform_info->enable_dma) {
                status = pxa2xx_spi_dma_setup(drv_data);
                if (status) {
-                       dev_dbg(dev, "no DMA channels available, using PIO\n");
+                       dev_warn(dev, "no DMA channels available, using PIO\n");
                        platform_info->enable_dma = false;
                } else {
                        controller->can_dma = pxa2xx_spi_can_dma;