]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pinctrl: tz1090: Delete an error message for a failed memory allocation in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 25 Dec 2017 16:55:48 +0000 (17:55 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 3 Jan 2018 07:46:52 +0000 (08:46 +0100)
Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-tz1090.c

index 74d1ffcc2199c2fe6f2835cc58f909dc32290127..2379ce2be3656c85f3e25b861982eb8daf83dcb3 100644 (file)
@@ -1082,10 +1082,8 @@ static int add_map_configs(struct device *dev,
 
        dup_configs = kmemdup(configs, num_configs * sizeof(*dup_configs),
                              GFP_KERNEL);
-       if (!dup_configs) {
-               dev_err(dev, "kmemdup(configs) failed\n");
+       if (!dup_configs)
                return -ENOMEM;
-       }
 
        (*map)[*num_maps].type = PIN_MAP_TYPE_CONFIGS_GROUP;
        (*map)[*num_maps].data.configs.group_or_pin = group;
@@ -1946,10 +1944,9 @@ static int tz1090_pinctrl_probe(struct platform_device *pdev)
        struct resource *res;
 
        pmx = devm_kzalloc(&pdev->dev, sizeof(*pmx), GFP_KERNEL);
-       if (!pmx) {
-               dev_err(&pdev->dev, "Can't alloc tz1090_pmx\n");
+       if (!pmx)
                return -ENOMEM;
-       }
+
        pmx->dev = &pdev->dev;
        spin_lock_init(&pmx->lock);