]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: mt7621-pci: add comment clarifying inverted reset lines
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Thu, 29 Nov 2018 18:39:55 +0000 (19:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Dec 2018 08:39:45 +0000 (09:39 +0100)
To avoid people reading this code being very confused, add a comment
clarifying the need for invert resets on some chip revisions.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/mt7621-pci/pci-mt7621.c

index c5e33fbdf225dac187e37ad10f6eace6c0ffdba5..31310b6fb7dbee31f08f2ec260f9c838cdb6e207 100644 (file)
@@ -589,6 +589,10 @@ static int mt7621_pcie_init_port(struct mt7621_pcie_port *port)
        u32 slot = port->slot;
        u32 val = 0;
 
+       /*
+        * Any MT7621 Ralink pcie controller that doesn't have 0x0101 at
+        * the end of the chip_id has inverted PCI resets.
+        */
        mt7621_reset_port(port);
 
        val = read_config(pcie, slot, PCIE_FTS_NUM);