]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: host: oxu210hp-hcd: remove set but not used variables 'uframes, transfer_buffer_...
authorYueHaibing <yuehaibing@huawei.com>
Fri, 15 Feb 2019 12:35:13 +0000 (12:35 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Feb 2019 13:41:38 +0000 (14:41 +0100)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/usb/host/oxu210hp-hcd.c: In function 'scan_periodic':
drivers/usb/host/oxu210hp-hcd.c:2256:13: warning:
 variable 'uframes' set but not used [-Wunused-but-set-variable]

drivers/usb/host/oxu210hp-hcd.c: In function 'oxu_urb_enqueue':
drivers/usb/host/oxu210hp-hcd.c:2835:6: warning:
 variable 'transfer_buffer_length' set but not used [-Wunused-but-set-variable]

They are never used since introduction.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/oxu210hp-hcd.c

index f06a291f05f8f9ee3fc6cb57c9c2f125a38f6be3..47c5515a9ce4aba55a1dc670a2e46f72f4e411e8 100644 (file)
@@ -2253,16 +2253,12 @@ static void scan_periodic(struct oxu_hcd *oxu)
        for (;;) {
                union ehci_shadow       q, *q_p;
                __le32                  type, *hw_p;
-               unsigned                uframes;
 
                /* don't scan past the live uframe */
                frame = now_uframe >> 3;
-               if (frame == (clock >> 3))
-                       uframes = now_uframe & 0x07;
-               else {
+               if (frame != (clock >> 3)) {
                        /* safe to scan the whole frame at once */
                        now_uframe |= 0x07;
-                       uframes = 8;
                }
 
 restart:
@@ -2832,7 +2828,6 @@ static int oxu_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
 {
        struct oxu_hcd *oxu = hcd_to_oxu(hcd);
        int num, rem;
-       int transfer_buffer_length;
        void *transfer_buffer;
        struct urb *murb;
        int i, ret;
@@ -2843,7 +2838,6 @@ static int oxu_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
 
        /* Otherwise we should verify the USB transfer buffer size! */
        transfer_buffer = urb->transfer_buffer;
-       transfer_buffer_length = urb->transfer_buffer_length;
 
        num = urb->transfer_buffer_length / 4096;
        rem = urb->transfer_buffer_length % 4096;