]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dma-buf/sw-sync: Prevent user overflow on timeline advance
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 29 Jun 2017 12:59:26 +0000 (13:59 +0100)
committerGustavo Padovan <gustavo.padovan@collabora.com>
Thu, 29 Jun 2017 21:52:05 +0000 (18:52 -0300)
The timeline is u32, which limits any single advance to INT_MAX so that
we can detect all fences that need signaling.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170629125930.821-3-chris@chris-wilson.co.uk
drivers/dma-buf/sw_sync.c

index 4d5d8c5e2534dae335a99f3f1a86f9f34a1e9b16..0e676d08aa70087b2daaa7c0cab0f896d16bcf42 100644 (file)
@@ -345,6 +345,11 @@ static long sw_sync_ioctl_inc(struct sync_timeline *obj, unsigned long arg)
        if (copy_from_user(&value, (void __user *)arg, sizeof(value)))
                return -EFAULT;
 
+       while (value > INT_MAX)  {
+               sync_timeline_signal(obj, INT_MAX);
+               value -= INT_MAX;
+       }
+
        sync_timeline_signal(obj, value);
 
        return 0;