]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
PCMCIA/i82092: move assignment out of if condition
authorSimon Geis <simon.geis@fau.de>
Fri, 13 Dec 2019 13:53:10 +0000 (14:53 +0100)
committerDominik Brodowski <linux@dominikbrodowski.net>
Mon, 16 Dec 2019 10:49:53 +0000 (11:49 +0100)
Improve readability by moving the assignment out of if conditions.

Co-developed-by: Lukas Panzer <lukas.panzer@fau.de>
Signed-off-by: Lukas Panzer <lukas.panzer@fau.de>
Signed-off-by: Simon Geis <simon.geis@fau.de>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
drivers/pcmcia/i82092.c

index c7996fe256225185d98643496078dfc5c338fdfa..2d31832fa43916b678e6603e740fbb7626ed068a 100644 (file)
@@ -77,7 +77,8 @@ static int i82092aa_pci_probe(struct pci_dev *dev, const struct pci_device_id *i
 
        enter("i82092aa_pci_probe");
 
-       if ((ret = pci_enable_device(dev)))
+       ret = pci_enable_device(dev);
+       if (ret)
                return ret;
 
        pci_read_config_byte(dev, 0x40, &configbyte);  /* PCI Configuration Control */
@@ -133,7 +134,9 @@ static int i82092aa_pci_probe(struct pci_dev *dev, const struct pci_device_id *i
 
        /* Register the interrupt handler */
        dev_dbg(&dev->dev, "Requesting interrupt %i\n", dev->irq);
-       if ((ret = request_irq(dev->irq, i82092aa_interrupt, IRQF_SHARED, "i82092aa", i82092aa_interrupt))) {
+       ret = request_irq(dev->irq, i82092aa_interrupt, IRQF_SHARED,
+                         "i82092aa", i82092aa_interrupt);
+       if (ret) {
                dev_err(&dev->dev, "Failed to register IRQ %d, aborting\n",
                        dev->irq);
                goto err_out_free_res;