]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
clk: tegra: emc: Fix EMC max-rate clamping
authorDmitry Osipenko <digetx@gmail.com>
Sun, 14 Apr 2019 19:23:19 +0000 (22:23 +0300)
committerStephen Boyd <sboyd@kernel.org>
Thu, 25 Apr 2019 20:54:20 +0000 (13:54 -0700)
When a clk user requests rate that is higher than the maximum possible,
the rate shall be clamped to the maximum and not to the current value.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/tegra/clk-emc.c

index 28068584ff6ed183b2b324286a6f0ebd3963ffcb..9a01792359396409fd4d537b2dacdd6c84aba54a 100644 (file)
@@ -121,7 +121,7 @@ static int emc_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
        struct tegra_clk_emc *tegra;
        u8 ram_code = tegra_read_ram_code();
        struct emc_timing *timing = NULL;
-       int i, k;
+       int i, k, t;
 
        tegra = container_of(hw, struct tegra_clk_emc, hw);
 
@@ -130,12 +130,17 @@ static int emc_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
                        break;
        }
 
-       for (i = k; i < tegra->num_timings; i++) {
-               if (tegra->timings[i].ram_code != ram_code)
+       for (t = k; t < tegra->num_timings; t++) {
+               if (tegra->timings[t].ram_code != ram_code)
                        break;
+       }
 
+       for (i = k; i < t; i++) {
                timing = tegra->timings + i;
 
+               if (timing->rate < req->rate && i != t - 1)
+                       continue;
+
                if (timing->rate > req->max_rate) {
                        i = max(i, k + 1);
                        req->rate = tegra->timings[i - 1].rate;
@@ -145,10 +150,8 @@ static int emc_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
                if (timing->rate < req->min_rate)
                        continue;
 
-               if (timing->rate >= req->rate) {
-                       req->rate = timing->rate;
-                       return 0;
-               }
+               req->rate = timing->rate;
+               return 0;
        }
 
        if (timing) {