]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlwifi: pcie: use the cfg we passed to iwl_trans_pcie_alloc()
authorLuca Coelho <luciano.coelho@intel.com>
Thu, 2 Aug 2018 13:16:27 +0000 (16:16 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 6 Sep 2019 12:35:43 +0000 (15:35 +0300)
Instead of using iwl_trans->cfg in iwl_trans_pcie_alloc(), use the
local argument that we received.  This will allow us to not to set the
cfg during iwl_trans_alloc() so it can be decided later.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/pcie/trans.c

index db75a79aa8a48ddcf0b1c462e4b2067140e4c325..a1164a0a384fc2c02ea1f4a40363ea14e744b977 100644 (file)
@@ -3481,7 +3481,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(struct pci_dev *pdev,
         * "dash" value). To keep hw_rev backwards compatible - we'll store it
         * in the old format.
         */
-       if (trans->cfg->trans.device_family >= IWL_DEVICE_FAMILY_8000) {
+       if (cfg->trans.device_family >= IWL_DEVICE_FAMILY_8000) {
                unsigned long flags;
 
                trans->hw_rev = (trans->hw_rev & 0xfff0) |
@@ -3497,7 +3497,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(struct pci_dev *pdev,
                 * in-order to recognize C step driver should read chip version
                 * id located at the AUX bus MISC address space.
                 */
-               ret = iwl_finish_nic_init(trans, &trans->cfg->trans);
+               ret = iwl_finish_nic_init(trans, &cfg->trans);
                if (ret)
                        goto out_no_pci;
 
@@ -3524,7 +3524,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(struct pci_dev *pdev,
 #if IS_ENABLED(CONFIG_IWLMVM)
        trans->hw_rf_id = iwl_read32(trans, CSR_HW_RF_ID);
 
-       if (trans->cfg == &iwlax210_2ax_cfg_so_hr_a0) {
+       if (cfg == &iwlax210_2ax_cfg_so_hr_a0) {
                if (trans->hw_rev == CSR_HW_REV_TYPE_TY) {
                        trans->cfg = &iwlax210_2ax_cfg_ty_gf_a0;
                } else if (CSR_HW_RF_ID_TYPE_CHIP_ID(trans->hw_rf_id) ==