]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
USB: isp116x-hcd.c: move assignment out of if () block
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Apr 2015 09:32:55 +0000 (11:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 May 2015 14:01:11 +0000 (16:01 +0200)
We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

CC: Olav Kongas <ok@artecdesign.ee>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Felipe Balbi <balbi@ti.com>
drivers/usb/host/isp116x-hcd.c

index 13181dcd98204b868aeafe9a00f72f3924b69abb..d089b3fb7a13dc8e02ad781765c78c87815e6a11 100644 (file)
@@ -500,7 +500,8 @@ static void start_atl_transfers(struct isp116x *isp116x)
        if (isp116x->periodic_count) {
                isp116x->fmindex = index =
                    (isp116x->fmindex + 1) & (PERIODIC_SIZE - 1);
-               if ((load = isp116x->load[index])) {
+               load = isp116x->load[index];
+               if (load) {
                        /* Bring all int transfers for this frame
                           into the active queue */
                        isp116x->atl_active = last_ep =