block: remove __blk_put_request()

Now there's no difference between blk_put_request() and
__blk_put_request() anymore, get rid of the underscore version and
convert the few callers.

Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/block/blk-core.c b/block/blk-core.c
index 18538a41a532d249f31e64d73ad546912a25ba37..700dd4587282afee199ddc6d852489c88558a091 100644 (file)
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -803,15 +803,6 @@ void part_round_stats(struct request_queue *q, int cpu, struct hd_struct *part)
 }
 EXPORT_SYMBOL_GPL(part_round_stats);
 
-void __blk_put_request(struct request_queue *q, struct request *req)
-{
-       if (unlikely(!q))
-               return;
-
-       blk_mq_free_request(req);
-}
-EXPORT_SYMBOL_GPL(__blk_put_request);
-
 void blk_put_request(struct request *req)
 {
        blk_mq_free_request(req);

diff --git a/block/blk-merge.c b/block/blk-merge.c
index c068c30b0c35403a031f840f369eb17c99ccf24e..3d073305da33cb760d583e4755e29026870e0a27 100644 (file)
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -866,7 +866,7 @@ int blk_attempt_req_merge(struct request_queue *q, struct request *rq,
 
        free = attempt_merge(q, rq, next);
        if (free) {
-               __blk_put_request(q, free);
+               blk_put_request(free);
                return 1;
        }
 

diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
index e19fa883376f5c6b0e04e5a8396e50ff0232a9d5..60cf7c5eb8805d7b69509218aa129b3955b2a09d 100644 (file)
--- a/drivers/scsi/osd/osd_initiator.c
+++ b/drivers/scsi/osd/osd_initiator.c
@@ -506,11 +506,11 @@ static void osd_request_async_done(struct request *req, blk_status_t error)
 
        _set_error_resid(or, req, error);
        if (req->next_rq) {
-               __blk_put_request(req->q, req->next_rq);
+               blk_put_request(req->next_rq);
                req->next_rq = NULL;
        }
 
-       __blk_put_request(req->q, req);
+       blk_put_request(req);
        or->request = NULL;
        or->in.req = NULL;
        or->out.req = NULL;

diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index 7a1a1edde35d372246847d0e5d1af39b9c33de84..664c1238a87fa28b565982bee11c8fd3a09dddf7 100644 (file)
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -341,7 +341,7 @@ static void osst_end_async(struct request *req, blk_status_t status)
                blk_rq_unmap_user(SRpnt->bio);
        }
 
-       __blk_put_request(req->q, req);
+       blk_put_request(req);
 }
 
 /* osst_request memory management */

diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index fff128aa9ec25f4b2034ba23de3b3983c4717d5f..dd338a8cd2757c84698830acf8fd5e6bd942e527 100644 (file)
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -1932,7 +1932,7 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
 
 static void eh_lock_door_done(struct request *req, blk_status_t status)
 {
-       __blk_put_request(req->q, req);
+       blk_put_request(req);
 }
 
 /**

diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index c6ad00703c5b0b6c3b4d72087649407b0a6f4cfd..4e27460ec92676433d00669ce8e18f137cc30e12 100644 (file)
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1390,7 +1390,7 @@ sg_rq_end_io(struct request *rq, blk_status_t status)
         */
        srp->rq = NULL;
        scsi_req_free_cmd(scsi_req(rq));
-       __blk_put_request(rq->q, rq);
+       blk_put_request(rq);
 
        write_lock_irqsave(&sfp->rq_list_lock, iflags);
        if (unlikely(srp->orphan)) {

diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 307df2fa39a3821a378dc8f96a8796b79032c8d2..7ff22d3f03e361f1f58f4f0e18594e1e70d3a3d3 100644 (file)
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -530,7 +530,7 @@ static void st_scsi_execute_end(struct request *req, blk_status_t status)
                complete(SRpnt->waiting);
 
        blk_rq_unmap_user(tmp);
-       __blk_put_request(req->q, req);
+       blk_put_request(req);
 }
 
 static int st_scsi_execute(struct st_request *SRpnt, const unsigned char *cmd,

diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index 47d76c862014732b7da469dc35e74ee27cc223de..c062d363dce36851b8f46ebfa833dab7b3aeff6d 100644 (file)
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -1094,7 +1094,7 @@ static void pscsi_req_done(struct request *req, blk_status_t status)
                break;
        }
 
-       __blk_put_request(req->q, req);
+       blk_put_request(req);
        kfree(pt);
 }
 

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index a9f6db8abcdae4527b1f852692525d28d55a2fc6..c502a7f40e843c69780dc1c71a7d7fb656485031 100644 (file)
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -906,7 +906,6 @@ extern blk_qc_t direct_make_request(struct bio *bio);
 extern void blk_rq_init(struct request_queue *q, struct request *rq);
 extern void blk_init_request_from_bio(struct request *req, struct bio *bio);
 extern void blk_put_request(struct request *);
-extern void __blk_put_request(struct request_queue *, struct request *);
 extern struct request *blk_get_request(struct request_queue *, unsigned int op,
                                       blk_mq_req_flags_t flags);
 extern int blk_lld_busy(struct request_queue *q);