]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
arch_topology: Convert switch block to if block
authorViresh Kumar <viresh.kumar@linaro.org>
Fri, 23 Jun 2017 09:25:31 +0000 (14:55 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Jul 2017 15:32:05 +0000 (17:32 +0200)
We only need to take care of one case here (CPUFREQ_NOTIFY) and there is
no need to add an extra level of indentation to the case specific code
by using a switch block. Use an if block instead.

Also add some blank lines to make the code look better.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Juri Lelli <juri.lelli@arm.com>
Tested-by: Juri Lelli <juri.lelli@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/arch_topology.c

index 0ad79b5cd56d060a64cbdeb55a0c45df521419af..a3cd7c869c3ee95e3ac270362f118a313a7e76e0 100644 (file)
@@ -174,26 +174,29 @@ init_cpu_capacity_callback(struct notifier_block *nb,
        if (cap_parsing_failed || cap_parsing_done)
                return 0;
 
-       switch (val) {
-       case CPUFREQ_NOTIFY:
-               pr_debug("cpu_capacity: init cpu capacity for CPUs [%*pbl] (to_visit=%*pbl)\n",
-                               cpumask_pr_args(policy->related_cpus),
-                               cpumask_pr_args(cpus_to_visit));
-               cpumask_andnot(cpus_to_visit, cpus_to_visit,
-                              policy->related_cpus);
-               for_each_cpu(cpu, policy->related_cpus) {
-                       raw_capacity[cpu] = topology_get_cpu_scale(NULL, cpu) *
-                                           policy->cpuinfo.max_freq / 1000UL;
-                       capacity_scale = max(raw_capacity[cpu], capacity_scale);
-               }
-               if (cpumask_empty(cpus_to_visit)) {
-                       topology_normalize_cpu_scale();
-                       kfree(raw_capacity);
-                       pr_debug("cpu_capacity: parsing done\n");
-                       cap_parsing_done = true;
-                       schedule_work(&parsing_done_work);
-               }
+       if (val != CPUFREQ_NOTIFY)
+               return 0;
+
+       pr_debug("cpu_capacity: init cpu capacity for CPUs [%*pbl] (to_visit=%*pbl)\n",
+                cpumask_pr_args(policy->related_cpus),
+                cpumask_pr_args(cpus_to_visit));
+
+       cpumask_andnot(cpus_to_visit, cpus_to_visit, policy->related_cpus);
+
+       for_each_cpu(cpu, policy->related_cpus) {
+               raw_capacity[cpu] = topology_get_cpu_scale(NULL, cpu) *
+                                   policy->cpuinfo.max_freq / 1000UL;
+               capacity_scale = max(raw_capacity[cpu], capacity_scale);
        }
+
+       if (cpumask_empty(cpus_to_visit)) {
+               topology_normalize_cpu_scale();
+               kfree(raw_capacity);
+               pr_debug("cpu_capacity: parsing done\n");
+               cap_parsing_done = true;
+               schedule_work(&parsing_done_work);
+       }
+
        return 0;
 }