]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pinctrl: sh-pfc: IPSRx and MOD_SELx should be set before GPSRx
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Wed, 16 Mar 2016 00:48:11 +0000 (00:48 +0000)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 29 Mar 2016 07:23:01 +0000 (09:23 +0200)
Gen2 / Gen3 datasheet will have below note in next version.
This patch follows this note.

IPSRx and MOD_SELx registers shall be set before setting GPSRx
registers in case that they need to be configured.
MOD_SELx registers can be set either earlier or later than setting
IPSRx registers.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/sh-pfc/sh_pfc.h

index a490834e208931cfda56f2980507489caa229d02..87140790d1f1e1fd8288013cbebbd6a0532f20bf 100644 (file)
@@ -276,7 +276,7 @@ struct sh_pfc_soc_info {
  *   - msel: Module selector
  */
 #define PINMUX_IPSR_MSEL(ipsr, fn, msel)                               \
-       PINMUX_DATA(fn##_MARK, FN_##msel, FN_##ipsr, FN_##fn)
+       PINMUX_DATA(fn##_MARK, FN_##msel, FN_##fn, FN_##ipsr)
 
 /*
  * Describe a pinmux configuration for a single-function pin with GPIO