]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: dapm: Cosmetic tidy up of snd_soc_dapm_new_control
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Wed, 5 Sep 2018 14:20:59 +0000 (15:20 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 5 Sep 2018 16:11:21 +0000 (17:11 +0100)
Move the function snd_soc_dapm_new_control to be next to
snd_soc_dapm_new_controls and add some kernel doc for it.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-dapm.c

index d13a25ce1275590690625293cc92d59e2bd0886a..c111e69b9a094efdb12925aab8d69999c80e829f 100644 (file)
@@ -3417,20 +3417,6 @@ int snd_soc_dapm_put_pin_switch(struct snd_kcontrol *kcontrol,
 }
 EXPORT_SYMBOL_GPL(snd_soc_dapm_put_pin_switch);
 
-struct snd_soc_dapm_widget *
-snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
-       const struct snd_soc_dapm_widget *widget)
-{
-       struct snd_soc_dapm_widget *w;
-
-       mutex_lock_nested(&dapm->card->dapm_mutex, SND_SOC_DAPM_CLASS_RUNTIME);
-       w = snd_soc_dapm_new_control_unlocked(dapm, widget);
-       mutex_unlock(&dapm->card->dapm_mutex);
-
-       return w;
-}
-EXPORT_SYMBOL_GPL(snd_soc_dapm_new_control);
-
 struct snd_soc_dapm_widget *
 snd_soc_dapm_new_control_unlocked(struct snd_soc_dapm_context *dapm,
                         const struct snd_soc_dapm_widget *widget)
@@ -3570,6 +3556,29 @@ snd_soc_dapm_new_control_unlocked(struct snd_soc_dapm_context *dapm,
        return ERR_PTR(ret);
 }
 
+/**
+ * snd_soc_dapm_new_control - create new dapm control
+ * @dapm: DAPM context
+ * @widget: widget template
+ *
+ * Creates new DAPM control based upon a template.
+ *
+ * Returns a widget pointer on success or an error pointer on failure
+ */
+struct snd_soc_dapm_widget *
+snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
+                        const struct snd_soc_dapm_widget *widget)
+{
+       struct snd_soc_dapm_widget *w;
+
+       mutex_lock_nested(&dapm->card->dapm_mutex, SND_SOC_DAPM_CLASS_RUNTIME);
+       w = snd_soc_dapm_new_control_unlocked(dapm, widget);
+       mutex_unlock(&dapm->card->dapm_mutex);
+
+       return w;
+}
+EXPORT_SYMBOL_GPL(snd_soc_dapm_new_control);
+
 /**
  * snd_soc_dapm_new_controls - create new dapm controls
  * @dapm: DAPM context