]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
cxgb4: kfree mhp after the debug print
authorShaobo He <shaobo@cs.utah.edu>
Thu, 28 Feb 2019 22:38:38 +0000 (15:38 -0700)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 4 Mar 2019 20:41:30 +0000 (16:41 -0400)
In function `c4iw_dealloc_mw`, variable mhp's value is printed after
freed, it is clearer to have the print before the kfree.

Otherwise racing threads could allocate another mhp with the same pointer
value and create confusing tracing.

Signed-off-by: Shaobo He <shaobo@cs.utah.edu>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/cxgb4/mem.c

index 8d1ab8273c2b99c969f3e47fe53ebde8defe4427..5baa31ab63664093215eeeb6f0d824bf428d4104 100644 (file)
@@ -678,8 +678,8 @@ int c4iw_dealloc_mw(struct ib_mw *mw)
                          mhp->wr_waitp);
        kfree_skb(mhp->dereg_skb);
        c4iw_put_wr_wait(mhp->wr_waitp);
-       kfree(mhp);
        pr_debug("ib_mw %p mmid 0x%x ptr %p\n", mw, mmid, mhp);
+       kfree(mhp);
        return 0;
 }