]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amd/display: correctly populate dpp refclk in fpga
authorAnthony Koo <Anthony.Koo@amd.com>
Fri, 27 Sep 2019 14:52:15 +0000 (10:52 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 25 Oct 2019 20:50:08 +0000 (16:50 -0400)
[Why]
In diags environment we are not programming the DPP DTO
correctly.

[How]
Populate the dpp refclk in dccg so it can be used to correctly
program DPP DTO.

Signed-off-by: Anthony Koo <Anthony.Koo@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c

index ecd2cb4840e38f36fe0809c0c752b444ab83102f..69daddbfbf29c4fee51590f62579aa05831e2f5c 100644 (file)
@@ -260,6 +260,8 @@ void dcn2_update_clocks_fpga(struct clk_mgr *clk_mgr,
                struct dc_state *context,
                bool safe_to_lower)
 {
+       struct clk_mgr_internal *clk_mgr_int = TO_CLK_MGR_INTERNAL(clk_mgr);
+
        struct dc_clocks *new_clocks = &context->bw_ctx.bw.dcn.clk;
        /* Min fclk = 1.2GHz since all the extra scemi logic seems to run off of it */
        int fclk_adj = new_clocks->fclk_khz > 1200000 ? new_clocks->fclk_khz : 1200000;
@@ -297,14 +299,18 @@ void dcn2_update_clocks_fpga(struct clk_mgr *clk_mgr,
                clk_mgr->clks.dispclk_khz = new_clocks->dispclk_khz;
        }
 
-       /* Both fclk and dppclk ref are run on the same scemi clock so we
-        * need to keep the same value for both
+       /* Both fclk and ref_dppclk run on the same scemi clock.
+        * So take the higher value since the DPP DTO is typically programmed
+        * such that max dppclk is 1:1 with ref_dppclk.
         */
        if (clk_mgr->clks.fclk_khz > clk_mgr->clks.dppclk_khz)
                clk_mgr->clks.dppclk_khz = clk_mgr->clks.fclk_khz;
        if (clk_mgr->clks.dppclk_khz > clk_mgr->clks.fclk_khz)
                clk_mgr->clks.fclk_khz = clk_mgr->clks.dppclk_khz;
 
+       // Both fclk and ref_dppclk run on the same scemi clock.
+       clk_mgr_int->dccg->ref_dppclk = clk_mgr->clks.fclk_khz;
+
        dm_set_dcn_clocks(clk_mgr->ctx, &clk_mgr->clks);
 }