]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dmaengine: imx-sdma: Remove call to memset after dma_alloc_coherent
authorFuqian Huang <huangfq.daxian@gmail.com>
Mon, 15 Jul 2019 03:17:16 +0000 (11:17 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 8 Aug 2019 12:21:43 +0000 (17:51 +0530)
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Link: https://lore.kernel.org/r/20190715031716.6328-1-huangfq.daxian@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/imx-sdma.c

index a01f4b5d793c4ed591b6666110b7ed00e5bce8e6..9ba74ab7e912e90fe78ab9f02b4120d79ab14fb4 100644 (file)
@@ -1886,10 +1886,6 @@ static int sdma_init(struct sdma_engine *sdma)
        sdma->context_phys = ccb_phys +
                MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control);
 
-       /* Zero-out the CCB structures array just allocated */
-       memset(sdma->channel_control, 0,
-                       MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control));
-
        /* disable all channels */
        for (i = 0; i < sdma->drvdata->num_events; i++)
                writel_relaxed(0, sdma->regs + chnenbl_ofs(sdma, i));