]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amdgpu/discovery: stop converting the units of base addresses
authorXiaojie Yuan <xiaojie.yuan@amd.com>
Wed, 27 Mar 2019 12:27:20 +0000 (20:27 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 21 Jun 2019 23:58:21 +0000 (18:58 -0500)
the unit is already in dword

Signed-off-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

index 5f967ae8d4ed3cb7f06a751a5cb68237f6b5f68d..697800c4741f6ea6ce158a816e79957898714395 100644 (file)
@@ -300,11 +300,11 @@ int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev)
 
                                        for (k = 0; k < num_base_address; k++) {
                                                /*
-                                                * convert the endianness and unit (in dword) of base addresses in place,
+                                                * convert the endianness of base addresses in place,
                                                 * so that we don't need to convert them when accessing adev->reg_offset.
                                                 */
-                                               ip->base_address[k] = le32_to_cpu(ip->base_address[k]) >> 2;
-                                               DRM_DEBUG("\t0x%08x\n", ip->base_address[k] << 2);
+                                               ip->base_address[k] = le32_to_cpu(ip->base_address[k]);
+                                               DRM_DEBUG("\t0x%08x\n", ip->base_address[k]);
                                        }
 
                                        adev->reg_offset[hw_ip][ip->number_instance] =