]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: hpsa: remove coalescing settings for ioaccel2
authorDon Brace <don.brace@microsemi.com>
Mon, 30 Jan 2017 22:05:17 +0000 (16:05 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 1 Feb 2017 02:51:16 +0000 (21:51 -0500)
- Setting coalescing has a significant negative impact on low
  queue-depth performance.
- Does not help high queue-depth performance.

Signed-off-by: Don Brace <don.brace@microsemi.com>
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hpsa.c

index cbc0c5fe5a60188515dab3dd99be83ce62732e1c..4323ddcf9718fd2a781edcf76cf6d9cbdfe25342 100644 (file)
@@ -9263,13 +9263,9 @@ static int hpsa_enter_performant_mode(struct ctlr_info *h, u32 trans_support)
                access = SA5_ioaccel_mode1_access;
                writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
                writel(4, &h->cfgtable->HostWrite.CoalIntCount);
-       } else {
-               if (trans_support & CFGTBL_Trans_io_accel2) {
+       } else
+               if (trans_support & CFGTBL_Trans_io_accel2)
                        access = SA5_ioaccel_mode2_access;
-                       writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
-                       writel(4, &h->cfgtable->HostWrite.CoalIntCount);
-               }
-       }
        writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL);
        if (hpsa_wait_for_mode_change_ack(h)) {
                dev_err(&h->pdev->dev,