]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 1 Feb 2019 09:18:41 +0000 (09:18 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 9 Feb 2019 10:33:37 +0000 (11:33 +0100)
It's not necessary to remove gpio_chip which added with
devm_gpiochip_add_data().

Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-tqmx86.c

index 6f7250c6f597512c1cd7681dea11a3966825cc05..33dbe483f92fe2d50e6367ef2b085f60388262e3 100644 (file)
@@ -291,7 +291,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
                                           IRQ_TYPE_EDGE_BOTH);
                if (ret) {
                        dev_err(dev, "Could not add irq chip\n");
-                       goto out_remove;
+                       goto out_pm_dis;
                }
 
                gpiochip_set_chained_irqchip(chip, irq_chip,
@@ -309,8 +309,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
 
        return 0;
 
-out_remove:
-       gpiochip_remove(&gpio->chip);
 out_pm_dis:
        pm_runtime_disable(&pdev->dev);